Linux kernel missed I/O errors in dm-crypt completion
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ b35f8caa0890169000fec22902290d9a15274cbd · < ac5d887ab93592fc5e3605fe30c1d8d232d609b3| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
dm-crypt: fix a tiny race condition in crypt_dec_pending
crypt_dec_pending reads io->error before calling atomic_dec_and_test. Another context, for example crypt_endio called from an interrupt, may set io->error and drop its reference between the read and the decrement. crypt_dec_pending then drops the last reference and completes the bio with the stale status - so a read that failed and was never decrypted, or a write that failed, is reported as successful.
The read was placed before the decrement by commit b35f8caa0890 ("dm crypt: wait for endio to complete before destruction"), because that commit freed dm_crypt_io before calling bio_endio. This is no longer the case, dm_crypt_io lives in the per-bio data now.
Read io->error after atomic_dec_and_test instead. atomic_dec_and_test is fully ordered, so no additional barrier is needed.
From the CVE record · Linux
A race in the Linux kernel's dm-crypt crypt_dec_pending function can cause a failed read or write to be reported as successful. The input does not describe an attacker action, access requirements, or user interaction.
Engineers running Linux kernels with dm-crypt should check their exposure; affected versions are not specified.