usb: gadget: aspeed-vhub: cancel wake work on device removal
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 7ecca2a4080cb6b1fa174adc588fce9e9014c43c · < 474e9e1852fb5ba0bfb26f123dd0cb361d0f4f4d| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
usb: gadget: aspeed-vhub: cancel wake work on device removal
wake_work is armed from the gadget .wakeup callback to resume suspended downstream ports, and it is never cancelled in ast_vhub_remove(), so a work item queued before or during removal can run after devm has freed vhub and its ports, a use-after-free.
Cancelling the work alone is not sufficient: usb_gadget_wakeup() takes no lock and the unbind path never clears wakeup_en, so a remote-wakeup request in flight on another CPU can re-arm the work after the cancel and before vhub is freed.
ast_vhub_del_dev() already clears d->registered under vhub->lock before unregistering the gadget. Refuse the wakeup in ast_vhub_udc_wakeup() once d->registered is clear: the check and the schedule_work() are then atomic against the unbind, so a wakeup that passed before the flag was cleared is drained by the cancel_work_sync() after the del_dev loop, and one that arrives later returns without arming. Also move INIT_WORK() to the top of ast_vhub_probe(), since the probe error path reuses ast_vhub_remove() and would otherwise cancel a never-initialized work item.
This issue was found by an in-house static analysis tool.
From the CVE record · Linux
The Linux kernel’s aspeed-vhub USB gadget driver can run queued wake work after device removal has freed the associated memory. An in-flight remote-wakeup request can re-arm the work during removal, causing a use-after-free. The input does not specify whether an attacker can trigger this remotely or locally, or whether authentication or user interaction is needed.
Engineers running Linux kernels with the aspeed-vhub USB gadget driver should check their versions; affected versions are not specified.