USB: gadget: dummy-hcd: Fix wait for outstanding request completions
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 7dbd8f4cabd96db5a50513de9d83a8105a5ffc81 · < 5298c96bf0068f3160969f7ddad81976d01a9b66| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
USB: gadget: dummy-hcd: Fix wait for outstanding request completions
The dummy-hcd driver emulates synchronize_irq() by waiting until its private callback_usage counter drops to 0 (with the private lock not held). This counter is incremented whenever a gadget driver callback occurs (which requires the private lock to be dropped), but not when a request completion handler is called.
This is an oversight. Request completion is triggered by timer interrupts (emulating device IRQs in a real UDC), and the interrupt handlers are supposed to have completed when the synchronize_irq() emulation routine returns -- they aren't supposed to be in the middle of a completion callback. If this happens it can lead to a gadget driver's unbind routine running before all outstanding request completions have finished, maybe even allowing the gadget driver's module to be unloaded while a completion handler is still running.
Fix the oversight by incrementing the callback_usage value across request completion callbacks.
From the CVE record · Linux
The Linux kernel's USB dummy-hcd driver can return from its interrupt-synchronization wait while a request completion callback is still running. If a gadget driver is unbound at that point, its module could be unloaded before the callback finishes. The input does not specify an attacker path, authentication requirements, or user interaction.
Engineers running Linux kernels with the USB dummy-hcd driver should check their deployments; affected versions are not specified.