HID: winwing: fix use-after-free in force feedback teardown
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
HID: winwing: fix use-after-free in force feedback teardown
winwing_init_ff() passes the driver's private data, allocated with devm_kzalloc() in winwing_probe(), as the effect context to input_ff_create_memless(). The memoryless force-feedback core takes ownership of that pointer and frees it with kfree() from input_ff_destroy() (ml_ff_destroy()) when the input device is destroyed.
Freeing a devm-managed allocation with kfree() is an invalid free, and the same object is then released again by devres when the HID device is torn down, a double free. As the allocation also embeds the LED class devices, their timers and work item live on freed memory and the slab gets corrupted. This triggers on unbind, rmmod, hot-unplug and on system suspend, where the firmware cache walks the now-corrupt devres list. KASAN reports:
BUG: KASAN: invalid-free in input_ff_destroy Allocated by task N: winwing_probe
Pass NULL as the memless context instead and fetch the driver data from the input device in winwing_play_effect(): the HID core already stores the hid_device as the input device's drvdata. The force-feedback core then owns nothing that it must not free.
From the CVE record · Linux
The Linux kernel’s HID winwing driver passes devm-managed memory to the force-feedback core, which frees it during teardown; the memory is later freed again, corrupting the slab. This can occur on device unbind, module removal, hot-unplug, or system suspend. The input does not specify attacker access requirements or user interaction.
Engineers running Linux kernels with the HID winwing driver should check whether their kernel includes the fix; affected versions are not specified.