bpf: fs/xattr: don't assume the inode is locked in path_unlink/path_rmdir
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
6.18.557.2.97.3In the Linux kernel, the following vulnerability has been resolved:
bpf: fs/xattr: don't assume the inode is locked in path_unlink/path_rmdir
bpf_lsm_has_d_inode_locked() makes the verifier rewrite bpf_[set|remove]_dentry_xattr() to the _locked variants, which assume that the caller already holds the inode's i_rwsem. The path_unlink and path_rmdir hooks are listed, but security_path_unlink() and security_path_rmdir() run before vfs_unlink()/vfs_rmdir() take the victim inode's i_rwsem, so a sleepable BPF LSM program attached to either hook mutates the victim's xattrs without the lock held.
Drop the two path hooks from d_inode_locked_hooks so that the verifier keeps the locking bpf_[set|remove]_dentry_xattr() variants, which take the lock themselves.
From the CVE record · Linux
The Linux kernel incorrectly assumes the victim inode is locked when a sleepable BPF LSM program changes its extended attributes from the path_unlink or path_rmdir hook. This can allow those attributes to be changed without the required lock; the input does not specify attacker access requirements or user interaction.
Engineers running Linux kernels that support sleepable BPF LSM programs should check whether their kernel is affected; no affected versions are specified.