scsi: libiscsi_tcp: Check the data direction of a Data-In PDU
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ a081c13e39b5c17052a7b46fafa61019c4c110ff · < ee56b5e18f566c0b5a183379dcd63d402cebf2f8| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
scsi: libiscsi_tcp: Check the data direction of a Data-In PDU
The Data-In branch of iscsi_tcp_hdr_dissect() resolves the ITT to a task and copies the PDU's data segment into that command's scatterlist without asking whether the command was reading. iscsi_tcp_r2t_rsp() in the same file does ask, and rejects an R2T for a command that is not DMA_TO_DEVICE.
A target that answers a WRITE command's ITT with a Data-In therefore has the initiator write target-supplied bytes into the pages that write was about to send. Those are the caller's own pinned pages for an O_DIRECT write, and page cache pages for a buffered one.
Observed against a test target that emits one 512-byte Data-In naming a 128 KB write's ITT, after the R2T for that write. With O_DIRECT the caller's buffer ends up holding 512 bytes of the target's data while pwrite() returns 131072. Buffered is quieter: pwrite() and fsync() both succeed, nothing is logged, and reading those blocks back returns the target's bytes out of the page cache without a command going on the wire.
Check the direction before using the scatterlist, the way the R2T path already does.
From the CVE record · Linux
The Linux kernel's libiscsi_tcp component accepts a Data-In response for an iSCSI WRITE command without checking the command's data direction. An iSCSI target that sends this response can overwrite the initiator's write buffer or page-cache pages with target-supplied data. The input does not specify authentication requirements or user interaction.
Engineers running Linux kernel iSCSI initiators should check their exposure; affected versions are not specified.