RDMA/siw: Clear association under lock if siw_qp_modify fails in siw_accept
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 6c52fdc244b5ccc468006fd65a504d4ee33743c7 · < 9dcc0f4e488b70cff81e0e5717a498c929cf5de3| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
RDMA/siw: Clear association under lock if siw_qp_modify fails in siw_accept
We need to clear cep before release state_lock as siw_qp_llp_close and siw_qp_modify->siw_qp_llp_close did.
Otherwise if siw_qp_modify() fails in siw_accept(), the QP's state_lock is released before the error path cleanup. A concurrent ibv_modify_qp() transitioning the QP to ERROR can race in this window:
siw_accept() ibv_modify_qp(ERROR) ---------------------- ---------------------- siw_qp_modify() fails up_write(&qp->state_lock) down_write(&qp->state_lock) nextstate_from_idle(): if (qp->cep) siw_cep_put(qp->cep) <- frees cep qp->cep = NULL goto error cep->qp = NULL <- UAF
Clear qp->cep and drop the association reference taken by siw_cep_get(), all under the write lock held from the initial down_write(&qp->state_lock). Thread B therefore sees qp->cep == NULL, skips its own put, and cannot free the cep before siw_accept() is done with it.
From the CVE record · Linux
The Linux kernel’s RDMA/siw code has a race in connection acceptance error handling. If siw_qp_modify() fails while a concurrent queue-pair transition to ERROR occurs, the code can use a freed connection endpoint. The input does not specify access requirements or user interaction.
Engineers running Linux kernels with RDMA/siw should check whether their kernel is affected; affected versions are not specified.