Bluetooth: L2CAP: fix out-of-bounds write in l2cap_ecred_connect
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
Bluetooth: L2CAP: fix out-of-bounds write in l2cap_ecred_connect
l2cap_chan_connect() tries to ensure there are no more than L2CAP_ECRED_CONN_SCID_MAX pending ECRED channels, so they fit in the same L2CAP_ECRED_CONN_REQ that l2cap_ecred_connect() constructs.
However, the check only counts deferred channels. If 6 L2CAP sockets are connected at the same time in order DDDDND (D=deferred, N=non-deferred), the last can bump the total to max+1. It results to one __le16 written out of bounds of the scid array, and an invalid ECRED_CONN_REQ being sent.
Fix by leaving room for the non-deferred pending ECRED channels in the counting in l2cap_chan_connect(), so the limit can't be exceeded.
Move counting under same critical section where the channel is added. Although race conditions involving this appear unreachable, it's easier to see.
Also add WARN_ON_ONCE check in l2cap_ecred_defer_connect() to make this less brittle.
From the CVE record · Linux
The Linux kernel’s Bluetooth L2CAP code can write past an array in l2cap_ecred_connect. This can occur when six L2CAP sockets connect concurrently in a specific deferred/non-deferred order, causing an invalid connection request to be sent. The input does not specify whether authentication or user interaction is required.
Engineers running Linux kernels with the affected Bluetooth L2CAP code should check their versions; affected versions are not specified.