net: macb: fix NULL pointer dereference on unbind with fixed-link
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ d0c3601f2c4e12e7689b0f46ebc17525250ea8c3 · < 38b6be101006d3e7af972999f45d4f1e8250587a| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
net: macb: fix NULL pointer dereference on unbind with fixed-link
When the device tree describes a fixed-link and has no "mdio" child node, macb_mii_init() returns early without allocating the MDIO bus, leaving bp->mii_bus as NULL.
Two cleanup paths then dereference this NULL bus:
1. On driver unbind, macb_remove() unconditionally calls mdiobus_unregister(bp->mii_bus), which oopses:
Unable to handle kernel NULL pointer dereference at virtual address 00000000000004a8 pc : mdiobus_unregister+0x14/0xa4 lr : macb_remove+0x38/0xa4 Call trace: mdiobus_unregister+0x14/0xa4 (P) macb_remove+0x38/0xa4 platform_remove+0x20/0x30 device_release_driver_internal+0x1c8/0x224 unbind_store+0xb4/0xbc
2. On the probe error path in macb_probe(), reached when macb_mii_init() has succeeded but a subsequent step fails, the err_out_unregister_mdio label runs the same unconditional cleanup.
mdiobus_unregister() and mdiobus_free() do not guard against a NULL bus, so guard the calls in both macb_remove() and the probe error path.
From the CVE record · Linux
The Linux kernel’s macb driver can dereference a NULL MDIO bus when a device tree specifies a fixed-link without an mdio child node. Driver unbind, or a probe failure after macb_mii_init() succeeds, can trigger a kernel crash. The input does not describe a network attack or specify authentication requirements.
Engineers running Linux kernels with the macb driver and this fixed-link device-tree configuration should check their deployments; affected versions are not specified.