vhost-vdpa: don't install the eventfd_ctx_fdget() error in config_ctx
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 776f395004d829bbbf18c159ed9beb517a208c71 · < 65faf9eaa00e408e1406fbcf675c8c8d0e27ff2a| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
vhost-vdpa: don't install the eventfd_ctx_fdget() error in config_ctx
vhost_vdpa_set_config_call() swaps the eventfd_ctx_fdget() return value into v->config_ctx before checking it, so on failure the field briefly holds an ERR_PTR:
ctx = fd == VHOST_FILE_UNBIND ? NULL : eventfd_ctx_fdget(fd); swap(ctx, v->config_ctx);
if (!IS_ERR_OR_NULL(ctx)) eventfd_ctx_put(ctx);
if (IS_ERR(v->config_ctx)) { long ret = PTR_ERR(v->config_ctx);
v->config_ctx = NULL; return ret; }
Commit 0bde59c1723a ("vhost-vdpa: set v->config_ctx to NULL if eventfd_ctx_fdget() fails") added that clearing, and spelled out the invariant the rest of the file relies on: "we consider 'v->config_ctx' valid if it is not NULL". The window between the swap and the clearing still breaks it. vhost_vdpa_config_cb() only tests for NULL, so a config interrupt delivered inside the window hands the ERR_PTR to eventfd_signal().
From the CVE record · Linux
In the Linux kernel's vhost-vdpa code, a failed eventfd lookup can briefly leave an error pointer in the configuration context. If a configuration interrupt arrives during that window, the callback passes the pointer to eventfd_signal(). A rejected fd can also stop configuration interrupts until userspace installs a new fd.
Engineers running Linux kernels with vhost-vdpa should check whether their kernel includes the fix; affected versions were not specified.