virtio_input: stop callbacks before unregistering input device
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 271c865161c57cfabca45b93eaa712b19da365bc · < d7808b37da0a619cf1fa541c2384e783fecc2480| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
virtio_input: stop callbacks before unregistering input device
virtinput_remove() unregisters the input device before resetting the virtio device. virtinput_recv_events() drops vi->lock around input_event(), so clearing vi->ready does not stop a callback that passed the entry check. It can still use vi->idev, requeue buffers and kick the queue.
Reset first, as virtinput_freeze() already does. With the preceding core change, reset waits for callbacks before input_unregister_device() can free vi->idev. Recheck vi->ready after taking the lock again: keep draining completed events so an input packet is not truncated, but stop requeueing buffers and kicking the queue.
With evdev attached, input_unregister_handle() currently waits for an RCU grace period, which also waits out IRQ callbacks. This masks the lifetime bug on PCI and MMIO, but does not protect sleepable callbacks on other transports.
From the CVE record · Linux
During virtio input device removal, a callback can continue using the input device after it is unregistered. The described lifetime bug affects transports with sleepable callbacks; the input does not describe an attacker path, authentication requirement, or user interaction.
Engineers running Linux kernels that use virtio_input should check their versions; affected versions were not provided.