lockd: fix swapped arguments in nlmsvc_match_ip()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 4373ea84c84d8a96e99d3da99e813d3e36d1bd11 · < 0d72e78c9d38d5377a059a4837f82b65b91cdcf6| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
lockd: fix swapped arguments in nlmsvc_match_ip()
When releasing locks by server IP address via /proc/fs/nfsd/unlock_ip, nlmsvc_unlock_all_by_ip() calls nlm_traverse_files() with the server sockaddr as the opaque @data argument:
nlm_traverse_files(server_addr, nlmsvc_match_ip, NULL);
The match callback is later invoked from nlm_traverse_locks() as:
match(lockhost, host);
where the first argument is the nlm_host that owns the lock, and the second argument is the @data that was originally passed down (here the server sockaddr). This is the convention every other match callback relies on (nlmsvc_mark_host(), nlmsvc_same_host(), nlmsvc_is_client()): arg1 is the real nlm_host, arg2 is the caller-supplied reference value.
nlmsvc_match_ip() has had these two arguments reversed ever since the unlock-by-IP feature was introduced in commit 4373ea84c84d ("lockd: unlock lockd locks associated with a given server ip"):
From the CVE record · Linux
The Linux kernel’s lockd component reverses arguments when matching a server IP address during lock release. As a result, locks are generally not released for the requested IP when `/proc/fs/nfsd/unlock_ip` is used. The input does not describe an attacker path or authentication requirements.
Engineers running Linux kernels with the lockd unlock-by-IP feature should check their systems; affected versions are not specified.