ACPI: PCI: Clear driver_data on all paths that free the acpi_pci_root
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ db89b4f0dbab837d0f3de2c3e9427a8d5393afa3 · < 3eee4c21931dc048ce63b86809f04e4e6f0dcad5| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
ACPI: PCI: Clear driver_data on all paths that free the acpi_pci_root
acpi_pci_root_add() assigns the freshly allocated root to device->driver_data before dmar_device_add() and pci_acpi_scan_root(). Both failure paths reach the end: label where root is kfree()'d, but only the pci_acpi_scan_root() path clears driver_data first.
When dmar_device_add() fails during a hot-add, root is freed while device->driver_data still points at it. The ACPI core does not clear driver_data on attach failure, so a later acpi_pci_find_root() call may dereference this dangling pointer.
acpi_pci_root_remove() has the same problem: it frees root without clearing device->driver_data, leaving a dangling pointer behind after the root bridge is removed.
Move the NULL assignment to the shared end: label so every error path in acpi_pci_root_add() clears driver_data before freeing root, and clear it in acpi_pci_root_remove() as well, so the object is never left reachable through driver_data after being freed.
From the CVE record · Linux
The Linux kernel can leave a dangling pointer to a freed ACPI PCI root after a hot-add failure or root bridge removal. A later root lookup may dereference it; the input does not specify an attacker path, authentication requirement, or user interaction.
Engineers running the Linux kernel should check for this issue; affected versions are not specified.