nfc: nci: fix double completion race in nci_data_exchange_complete
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ d89b74bf08f067b55c03d7f999ba0a0e73177eb3 · < ba4c776af3dc21ed04e315e6545e99703bb1b53a| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
nfc: nci: fix double completion race in nci_data_exchange_complete
nci_close_device() and nci_rx_work can both call nci_data_exchange_complete() concurrently. After commit 4527025d440ce8 ("nfc: nci: fix circular locking dependency in nci_close_device") moved flush_workqueue(ndev->rx_wq) after mutex_unlock(&ndev->req_lock), rx_work is no longer serialized with the explicit completion call in the close path. Both callers read the non-NULL callback pointer and invoke rawsock_data_exchange_complete(), which calls sock_put() -- but only one sock_hold() was taken, so the second sock_put() underflows the refcount and frees the socket while it is still in use.
Replace the bare clear_bit(NCI_DATA_EXCHANGE) with test_and_clear_bit() so that only the first caller proceeds to invoke the callback.
From the CVE record · Linux
The Linux kernel's NFC NCI data-exchange completion can run twice when device-close and receive work execute concurrently. The second completion can underflow a socket reference count and free the socket while it is still in use. The input does not specify attacker access requirements or user interaction.
Engineers running Linux kernels with the affected NFC NCI code should check their kernel versions; affected versions are not specified.