ksmbd: defer publishing granted locks to prevent UAF/double-free race
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ e2f34481b24db2fd634b5edb0a5bd0e4d38cc6e9 · < 29f74f0f2e6df3b393b7b66e810136d0c64e3c59| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
ksmbd: defer publishing granted locks to prevent UAF/double-free race
In smb2_lock(), mid-batch granted locks are published to connection-wide (conn->lock_list) and file-wide (fp->lock_list) lists immediately upon vfs_lock_file() success, while also remaining tracked on the stack-local rollback_list.
If a subsequent element in the same SMB2_LOCK request array fails validation or execution, the thread jumps to out: and walks rollback_list to undo previously granted locks. However, because the granted lock was already published to conn->lock_list, a concurrent UNLOCK request on the same connection can find the lock object and kfree() it before the rollback loop executes.
When the granting thread subsequently walks rollback_list, it dereferences and frees the already-freed ksmbd_lock structure, resulting in a Use-After-Free and Double-Free (on both ksmbd_lock and struct file_lock).
Fix this by deferring the publication of granted locks to conn->lock_list and fp->lock_list until after the entire array of lock elements has been processed without error. Mid-batch grants remain tracked exclusively on the request-local rollback_list until the whole batch succeeds, eliminating the race window.
From the CVE record · Linux
The Linux kernel's ksmbd component can publish granted locks before an entire SMB2_LOCK request succeeds. If a later lock element fails and a concurrent UNLOCK on the same connection frees an earlier lock, the rollback path can dereference and free that lock again. The input does not specify authentication requirements.
Engineers running Linux kernels with ksmbd should check whether their kernel is affected; affected versions are not specified.