Revert "media: v4l2-dev: fix error handling in __video_register_device()"
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 2a934fdb01db6458288fc9386d3d8ceba6dd551a · < aad08b5f67d2a8116e1a00bce2611c1513b10bce| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
Revert "media: v4l2-dev: fix error handling in __video_register_device()"
This reverts commit 2a934fdb01db6458288fc9386d3d8ceba6dd551a.
The intentions of that patch were good, but it doesn't work.
The idea is that if device_register fails, you have to do a put_device to let the ref counter release resources.
However, the V4L2 API says that if video_register_device() fails, then you have to call video_device_release(), which kfree()s the video_device struct.
But the put_device() will already have freed the struct, so you end up in a double-free scenario.
There is not really a good way of fixing this without breaking video_register_device() into two parts, one that initializes everything, and one that does the actual device_register, and then converting all V4L2 drivers to this new model.
From the CVE record · Linux
A failure in V4L2 device registration can cause a double-free when the caller follows the V4L2 API and releases the video device. The input does not establish how an attacker could trigger the failure or whether access or user interaction is required.
Teams running Linux kernels with the affected V4L2 registration change should check their versions; affected versions are not specified.