NFSD: remove flawed WARN_ON_ONCE from nfsd_mode_check
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ e75b23f9e323b1e0759619c39d5a9f7a3a5d9d2c · < 7ef182a8fe9c12b0d936880b1e504840639aa009| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
NFSD: remove flawed WARN_ON_ONCE from nfsd_mode_check
The header for commit e75b23f9e323 ("nfsd: check d_can_lookup in fh_verify of directories") details the assumption that justified adding the WARN_ON_ONCE to nfsd_mode_check(), that assumption is invalid (in the case of NFS reexport).
When NFSD exports an NFS filesystem it is very possible for nfsd_mode_check() to encounter a @dentry that doesn't have i_op->lookup (see nfs_fhget()'s NFS_ATTR_FATTR_MOUNTPOINT and NFS_ATTR_FATTR_V4_REFERRAL handling, and d_flags_for_inode()).
So remove nfsd_mode_check()'s WARN_ON_ONCE(). The nfserr_notdir return on that branch must stay. It guards the subsequent lookup_one_unlocked() -> __lookup_slow() path, which calls inode->i_op->lookup() with no NULL check, so returning nfserr_notdir is what keeps a client LOOKUP into such a @dentry from dereferencing a NULL method pointer.
From the CVE record · Linux
NFSD has a flawed warning check that can trigger when it exports an NFS filesystem and encounters a directory entry without a lookup method. A client LOOKUP into such an entry can reach this check; the existing error return prevents a NULL method-pointer dereference. The input does not specify authentication requirements.
Operators running the Linux kernel with NFSD reexporting NFS filesystems should check their installations; affected versions are not specified.