platform/x86: hp-bioscfg: fix off-by-one write in hp_get_string_from_buffer()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
platform/x86: hp-bioscfg: fix off-by-one write in hp_get_string_from_buffer()
hp_get_string_from_buffer() clamps the converted string length against the destination buffer size with "size > dst_size", so when the converted length is exactly equal to dst_size, conv_dst_size is left at dst_size and the unconditional NUL terminator write
dst[conv_dst_size] = 0;
lands one byte past the destination buffer. This is the same shape of bug as the previously fixed off-by-one in hp_convert_hexstr_to_str(): the buffer is sized correctly for the content, but the terminator write is never checked against that size.
Fix by changing the comparison to ">=" so conv_dst_size is always left with room for the terminator.
All fixed-size destinations that reach this function (path[512], current_value[512], current_password/current_value[64], and the per-entry buffers in encodings[][512] and prerequisites[][512]) are affected.
From the CVE record · Linux
The Linux kernel's hp-bioscfg component has an off-by-one error in hp_get_string_from_buffer(). When a converted string exactly fills a destination buffer, its NUL terminator is written one byte past the buffer. The input does not specify how an attacker could reach this condition or whether authentication or user interaction is required.
Engineers running Linux kernels with the hp-bioscfg component should check their deployments; affected versions are not specified.