xfs: restore nofs context unconditionally in xfs_trans_roll
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
7.1.117.2.17.3In the Linux kernel, the following vulnerability has been resolved:
xfs: restore nofs context unconditionally in xfs_trans_roll
When __xfs_trans_commit() fails in xfs_trans_roll(), the NOFS context is cleared but only restored in the success path. This leaves the error path without nofs protection, causing a circular lock dependency between xfs_nondir_ilock_class and fs_reclaim:
CPU0 CPU1 ---- ---- lock(&xfs_nondir_ilock_class); lock(fs_reclaim); lock(&xfs_nondir_ilock_class); lock(fs_reclaim);
Fix this by moving xfs_trans_set_context() before the error check so that nofs context is always restored on the new transaction.
From the CVE record · Linux
In the Linux kernel, XFS fails to restore the NOFS context when a transaction commit fails during xfs_trans_roll(), leaving the error path exposed to a circular lock dependency. The input does not describe how an attacker could trigger this failure or specify access or user-interaction requirements.
Operators running Linux kernels with the affected XFS code should check their kernel version; affected versions are not specified.