HID: nintendo: stop device IO before hid_hw_stop on probe failure
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 2af16c1f846bd60240745bbd3afa13d5f040c61a · < 2e0d98dc8a6dea5fc2b72bf66e0dcbd5488644b4| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
HID: nintendo: stop device IO before hid_hw_stop on probe failure
nintendo_hid_probe() calls hid_device_io_start() before joycon_init() and joycon_leds_create(). If either fails, the error path jumps to err_close which calls hid_hw_close()/hid_hw_stop() without first calling hid_device_io_stop().
hid_hw_stop() does not stop device IO, so hid_input_report() may still run and access driver data that is being torn down, resulting in a use-after-free.
Add an err_io_stop label that calls hid_device_io_stop() before hid_hw_close(), and point the two post-io_start error paths at it.
From the CVE record · Linux
The Nintendo HID driver can access freed driver data if initialization fails after device I/O starts, because the error path stops the HID hardware without stopping device I/O first. This can cause a use-after-free; the input does not establish how an attacker could trigger it or whether access or user interaction is required.
Engineers running Linux kernels with the Nintendo HID driver should check their kernel version; affected versions are not specified.