hwmon: (occ) unregister sysfs devices outside occ lock
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 849b0156d9960da628a06756bb920d9571c15e66 · < e31408734332b8cc611342cdaaab6ba492180156| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
hwmon: (occ) unregister sysfs devices outside occ lock
occ_active(false) and occ_shutdown() unregister sysfs-backed devices while occ->lock is held. hwmon_device_unregister() and sysfs_remove_group() can wait for active sysfs callbacks to drain, and those callbacks can enter the OCC update path and try to take occ->lock again. That gives the unregister paths the lock ordering occ->lock -> sysfs callback drain, while a callback has the opposite edge sysfs callback -> occ->lock.
This issue was found by our static analysis tool and then manually reviewed against the current tree.
The grounded PoC kept the real unregister and callback carrier:
occ_shutdown() hwmon_device_unregister() occ_show_temp_1() occ_update_response()
Lockdep reported the circular dependency with occ_shutdown() already holding the OCC mutex and hwmon_device_unregister() waiting on the sysfs side:
WARNING: possible circular locking dependency detected ... (sysfs_lock) ... at: hwmon_device_unregister+0x12/0x30 [vuln_msv] ... (&test_occ.lock) ... at: occ_shutdown.constprop.0+0xe/0x40 [vuln_msv] occ_update_response.isra.0+0xb/0x20 [vuln_msv] occ_show_temp_1.constprop.0.isra.0+0x23/0x40 [vuln_msv] *** DEADLOCK ***
From the CVE record · Linux
The Linux kernel OCC hwmon driver can deadlock when device removal waits for an active sysfs callback while holding a lock that the callback also needs. This requires a sysfs callback to overlap with OCC shutdown or deactivation; the input does not establish whether an attacker can trigger it or what privileges are needed.
Engineers running Linux kernels with the OCC hwmon driver should check their kernel versions against the vendor advisory; affected versions were not provided.