mptcp: fastopen: only mark MPTFO subflows with SYN data
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
mptcp: fastopen: only mark MPTFO subflows with SYN data
Passive TCP Fast Open accepts a valid-cookie SYN even when it carries no data. In that case the child socket's receive queue is intentionally left empty.
mptcp_fastopen_subflow_synack_set_params() set is_mptfo before checking for queued SYN data. That made data-less TFO SYNs hit a WARN and, if the warning was non-fatal, left stale MPTFO state behind. The stale flag could later trigger a state-confusion bug in check_fully_established().
Only mark the subflow as MPTFO after confirming that an SKB was queued. Return quietly when the receive queue is empty.
Note that mptcp_subflow_context's is_mptfo field is now not just about subflows where the TFO was present, but about MPTFO subflow that consumed SYN data. Only having a valid cookie but not carrying data is not really "doing TFO".
From the CVE record · Linux
The Linux kernel's MPTCP Fast Open handling can incorrectly mark a subflow when it receives a valid-cookie SYN with no data. A network peer sending such a SYN can trigger a warning and, if the warning is non-fatal, leave stale state that may later cause state confusion. The input does not specify authentication or user-interaction requirements.
Engineers running Linux kernels with MPTCP Fast Open should check their kernel versions; affected versions are not specified.