net: tap: set skb->dev before parsing virtio net header in tap_get_user_xdp()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 924a9bc362a5223cd448ca08c3dde21235adc310 · < 3874892dd27d5387aa9a06f58d9060f18f351d24| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
net: tap: set skb->dev before parsing virtio net header in tap_get_user_xdp()
The commit 4f61f133f354 ("net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null") fixed a crash in tap_get_user() by assigning skb->dev before calling tun_vnet_hdr_to_skb(). This is required because virtio_net_hdr_to_skb() may invoke dev_parse_header_protocol(), which dereferences skb->dev. Without the assignment, a NULL pointer dereference can occur.
However, tap_get_user_xdp() still parses the virtio-net header before assigning skb->dev. When the vhost TX path passes an XDP buffer containing a GSO virtio-net header but the protocol is set to zero on purpose, tun_vnet_hdr_to_skb() can reach dev_parse_header_protocol() while skb->dev is still NULL, resulting in a crash.
Fix this by looking up the tap device and assigning skb->dev before calling tun_vnet_hdr_to_skb(), matching the ordering already used in tap_get_user(). Preserve the existing RCU read-side critical section across dev_queue_xmit().
From the CVE record · Linux
The Linux kernel’s tap_get_user_xdp() parses a virtio-net header before assigning skb->dev. A vhost TX path carrying an XDP buffer with a GSO virtio-net header and a zero protocol can trigger a NULL pointer dereference and crash. The input does not specify whether authentication or user interaction is required.
Engineers running Linux kernels with the affected TAP XDP path should check their kernel versions against the vendor advisory; affected versions are not specified.