netfilter: ipset: do not update comments from kernel-side hash adds
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ f66ee0410b1c3481ee75e5db9b34547b4d582465 · < 4ae701848e4ba9e9713375fb7d82218cbd309da2| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
netfilter: ipset: do not update comments from kernel-side hash adds
mtype_resize() copies comment pointers with memcpy(), not the comment objects themselves. During the window after an entry has been copied but before the table swap and backlog replay, the old table is still published for packet-side updates while the replacement-table entry already holds the same ip_set_comment_rcu pointer.
If xt_SET --add-set ... --exist hits that old entry in this window, mtype_add() calls ip_set_init_comment() even though packet-side adds carry no comment payload. That call frees the shared comment through the old entry, so the replacement-table entry now holds a stale pointer. When the queued add is replayed on the new table, mtype_add() calls ip_set_init_comment() again and strlen() dereferences the stale pointer.
Fix this in mtype_add() by skipping ip_set_init_comment() when ext->target marks a packet-side add. Userspace adds still update comments, while packet-side adds can no longer free comment storage shared with a resize copy.
From the CVE record · Linux
During an ipset hash resize, copied entries can temporarily share a comment pointer with the old table. If an xt_SET packet-side add with --exist updates an old entry in that window, replaying the add on the new table can dereference the stale pointer. The input does not specify authentication requirements or required user interaction.
Teams running the Linux kernel with netfilter ipset should check their deployments; affected versions were not specified.