configfs_lookup(): don't leave ->s_dentry dangling on failure
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 3d0f89bb169482d26d5aa4e82e763077e7e9bc4d · < 57088b06109f3222963c639d8d743f42c2899b13| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
configfs_lookup(): don't leave ->s_dentry dangling on failure
Normally ->s_dentry is cleared when dentry it's pointing to becomes negative (on eviction, realistically). However, that only happens if dentry gets to be positive in the first place; in case of inode allocation failure dentry never becomes positive, so ->d_iput() is not called at all.
We do part of what normally would've been done by configfs_d_iput() (dropping the reference to configfs_dirent) manually, but we do not clear ->s_dentry there. Sloppy as it is, it does not matter in case of configfs_create_{dir,link}() - there configfs_dirent does not survive dropping the sole reference to it.
However, for configfs_lookup() it *does* survive, with a dangling pointer to soon to be freed dentry sitting it its ->s_dentry.
Subsequent getdents(2) in that directory will end up dereferencing that pointer in order to pick the inode number. Use after free...
This is the minimal fix; the right approach is to set the linkage between dentry and configfs_dirent only after we know that we have an inode, but that takes more surgery and the bug had been there since 2006, so...
From the CVE record · Linux
In the Linux kernel, configfs_lookup() can leave a dangling pointer when inode allocation fails. A subsequent getdents(2) call in the directory dereferences the freed dentry, causing a use-after-free. The input does not specify whether authentication or user interaction is required.
Engineers running Linux kernels with configfs should check their exposure; affected versions are not specified.