usb: host: max3421: Fix shift-out-of-bounds in max3421_hub_control()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 2d53139f31626bad6f8983d8e519ddde2cbba921 · < 02d03c61e8a7b016956acb48e8a2512d16d87517| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
usb: host: max3421: Fix shift-out-of-bounds in max3421_hub_control()
The `max3421_hub_control()` function handles USB hub class requests to the virtual root hub. In the `default` branches of both the `ClearPortFeature` and `SetPortFeature` switch statements, it modifies `max3421_hcd->port_status` by left shifting 1 by the request's `value` parameter. However, it does not validate whether this shift will exceed the width of `port_status`.
So if a malicious userspace task with access to the root hub via /dev/bus/usb/.../001 issues a USBDEVFS_CONTROL ioctl with `wValue` greater than or equal to 32, the left shift operation invokes shift-out-of-bounds undefined behavior. This results in arbitrary bit corruption of `port_status`, including the normally-immutable change bits, which can bypass internal state checks and confuse the hub status.
Fix this by rejecting requests whose `value` exceeds the shift width before performing the shift.
This issue was found using a KLEE-based symbolic execution tool for kernel drivers that I'm currently developing.
From the CVE record · Linux
The Linux kernel’s max3421 USB host driver does not validate a shift value in virtual root hub requests. A local userspace task with access to the root hub can send a USBDEVFS_CONTROL ioctl with wValue of 32 or greater, corrupting port status bits and confusing hub status.
Anyone running a Linux kernel that uses the max3421 USB host driver should check whether their kernel includes the fix; affected versions were not specified.