mlxsw: fix refcount leak in mlxsw_sp_vrs_lpm_tree_replace()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ fc922bb0dd9406dd9897fd47df958789891c380e · < 3a2b47d1b4b3de54d030a7fdb6a322c970513ee3| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
mlxsw: fix refcount leak in mlxsw_sp_vrs_lpm_tree_replace()
When mlxsw_sp_vrs_lpm_tree_replace() fails after replacing some VRs, the error rollback loop does not correctly revert the preceding replacements. The loop decrements the index but fails to update the vr pointer, which still points to the VR that caused the failure. As a result, the condition and the rollback call always operate on the same VR, potentially calling mlxsw_sp_vr_lpm_tree_replace() multiple times on it while never rolling back the earlier VRs. Those VRs continue to hold a reference to new_tree acquired via mlxsw_sp_lpm_tree_hold(), leaking the reference count of new_tree.
Fix by reinitializing vr inside the error loop with the updated index:
vr = &mlxsw_sp->router->vrs[i];
so that the loop correctly iterates over all VRs that were actually replaced.
From the CVE record · Linux
The mlxsw rollback path can fail to release references when replacing a routing tree fails after some virtual routers have been updated. The input does not describe an attacker action or specify whether exploitation requires network access, authentication, local access, or user interaction.
Engineers running the Linux kernel with mlxsw should check their installations; affected versions are not specified.