mtd: spi-nor: swp: Improve locking user experience
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 3dd8012a8eeb3702fa17450ec1a16a3f38af138d · < c0806df5cf806545160f3fdac3c888926ceac557| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
mtd: spi-nor: swp: Improve locking user experience
In the case of the first block being locked (or the few first blocks), if the user want to fully unlock the device it has two possibilities: - either it asks to unlock the entire device, and this works; - or it asks to unlock just the block(s) that are currently locked, which fails.
It fails because the conditions "can_be_top" and "can_be_bottom" are true. Indeed, in this case, we unlock everything, so the TB bit does not matter. However in the current implementation, use_top would be true (as this is the favourite option) and lock_len, which in practice should be reduced down to 0, is set to "nor->params->size - (ofs + len)" which is a positive number. This is wrong.
An easy way is to simply add an extra condition. In the unlock() path, if we can achieve the same result from both sides, it means we unlock everything and lock_len must simply be 0. A comment is added to clarify that logic.
From the CVE record · Linux
The Linux kernel’s SPI-NOR software protection code can fail to unlock a device when a user requests only the locked first block or blocks, even though unlocking the entire device works. The input does not describe an attacker, an attack path, or authentication requirements; the failure requires a user to make the narrower unlock request.
Engineers running Linux kernels with SPI-NOR software protection should check their installations; affected versions are not specified.