drm/dp/mst: fix OOB reads in remote DPCD/I2C sideband reply parsers
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ ad7f8a1f9ced7f049f9b66d588723f243a7034cd · < 533d9e2bede4aeefdc2a0561d7071cfede95958f| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
drm/dp/mst: fix OOB reads in remote DPCD/I2C sideband reply parsers
drm_dp_sideband_parse_remote_dpcd_read() reads num_bytes from the raw message and then unconditionally does:
memcpy(bytes, &raw->msg[idx], num_bytes);
without checking that idx + num_bytes <= raw->curlen. raw->msg[] is 256 bytes; if a malicious or misbehaving MST hub sets num_bytes larger than the remaining payload, the memcpy reads past the received data into whatever follows in raw->msg[].
drm_dp_sideband_parse_remote_i2c_read_ack() has the same flaw (noted with a /* TODO check */ comment since the code was introduced).
Fix both functions by using a single combined check (idx + num_bytes > curlen) before each memcpy. Since num_bytes is u8, it is always >= 0, so this strictly subsumes the simpler idx > curlen form and no separate step is needed.
[added missing fixes tag]
From the CVE record · Linux
The Linux kernel’s DRM DP MST remote DPCD and I2C reply parsers can read beyond the received sideband payload. A malicious or misbehaving MST hub can trigger the reads by reporting more bytes than remain in a reply; the input does not specify authentication or user-interaction requirements.
Engineers running Linux kernels with DRM DP MST support should check their versions; affected versions are not specified.