media: vivid: check for vb2_is_busy() when toggling caps
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 73c3f48230cda01402ae189b05d56f1f7e0d53c9 · < 492c97cb50feaa60ccd7792d3d6b904ed8ec61bf| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
media: vivid: check for vb2_is_busy() when toggling caps
The vivid_update_format_cap/out() functions must only be called if the capture/output queue are not busy. But for the controls that select the CROP/COMPOSE/SCALE capability that is not checked.
Only when streaming starts will they be set to 'grabbed' and it is impossible to change the control, but between REQBUFS and STREAMON you are still allowed to set these controls. Since vivid_update_format_cap/out will change the format, this can cause unexpected results.
Besides adding these checks, also add a WARN_ON in vivid_update_format_cap/out() if the queue is busy.
I'm 90% certain that this is the cause of this syzbot bug:
https://syzkaller.appspot.com/bug?extid=dac8f5eaa46837e97b89
But since we never have reproducers, it is hard to be certain. In any case, these checks are needed regardless.
From the CVE record · Linux
The Linux kernel's vivid media driver does not check whether capture or output queues are busy when CROP, COMPOSE, or SCALE controls are changed. Someone able to change those controls between REQBUFS and STREAMON can trigger unexpected format changes. The input does not specify authentication requirements or a confirmed exploit.
Engineers running Linux kernels with the vivid media driver should check their systems; affected versions are not specified.