media: vivid: fix cleanup bugs in vivid_init()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ f46d740fb0258982f00ffdbddc6486e674edafb5 · < a07c179a92e949172ca52f6d4a13202ea88cd4b7| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
media: vivid: fix cleanup bugs in vivid_init()
When platform_device_register() fails in vivid_init(), the embedded struct device in vivid_pdev has already been initialized by device_initialize(), but the failure path jumps to free_output_strings without dropping the device reference for the current platform device:
vivid_init() -> platform_device_register(&vivid_pdev) -> device_initialize(&vivid_pdev.dev) -> setup_pdev_dma_masks(&vivid_pdev) -> platform_device_add(&vivid_pdev)
This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before jumping to the common cleanup path.
Also, the unreg_driver label incorrectly calls platform_driver_register() instead of platform_driver_unregister(), which breaks cleanup when workqueue creation fails after successful driver registration. Fix that as well.
The reference leak was identified by a static analysis tool I developed and confirmed by manual review. The incorrect cleanup call was found during code inspection.
From the CVE record · Linux
The Linux kernel’s vivid media driver has cleanup errors during initialization. If platform device registration fails, it leaks a device reference; if workqueue creation fails after driver registration, driver cleanup is incorrect. The input does not describe an attacker path or specify authentication or user-interaction requirements.
Engineers running Linux kernels with the vivid media driver should check their kernel version; affected versions are not specified.