fscrypt: Add missing superblock check in find_or_insert_direct_key()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 22e9947a4b2ba255888541bd0111cf00b9b16586 · < b5fa40226e71c17847b9ff2816c6ca4133d0d994| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
fscrypt: Add missing superblock check in find_or_insert_direct_key()
The legacy 'fscrypt_direct_keys' table caches master keys that are used by v1 encryption policies that have FSCRYPT_POLICY_FLAG_DIRECT_KEY. It's just a global table for all filesystems (since the keys can be provided by the legacy process-subscribed keyrings mechanism, which makes it difficult to reuse super_block::s_master_keys).
The entries in it ('struct fscrypt_direct_key') do contain a super_block pointer, though, for passing to fscrypt_destroy_inline_crypt_key() when the last inode that references the key is evicted.
However, when finding the fscrypt_direct_key for an inode, we weren't actually comparing the super_block pointer. As a result, inodes with different super_blocks could point to the same fscrypt_direct_key. That could extend the lifetime of a fscrypt_direct_key beyond the super_block it points to, causing a use-after-free later.
Fix this by creating distinct fscrypt_direct_key structs for distinct super_block structs.
Note that this problem doesn't exist in the v2 policy equivalent ("per-mode keys"), since the data structures there are per super_block.
From the CVE record · Linux
The Linux kernel’s fscrypt direct-key cache can share a key between inodes on different superblocks when using v1 encryption policies with FSCRYPT_POLICY_FLAG_DIRECT_KEY. This can keep the key alive beyond its superblock and cause a use-after-free; the input does not specify how an attacker could trigger it or whether authentication or user interaction is required.
Engineers running Linux kernels that use fscrypt v1 direct-key policies should check their versions; affected versions are not specified.