firmware_loader: fix device reference leak in firmware_upload_register()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 97730bbb242cde22b7140acd202ffd88823886c9 · < 896df22ee57648b0c505bd76ddbc6b2341834696| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
firmware_loader: fix device reference leak in firmware_upload_register()
firmware_upload_register() -> fw_create_instance() -> device_initialize()
After fw_create_instance() succeeds, the lifetime of the embedded struct device is expected to be managed through the device core reference counting, since fw_create_instance() has already called device_initialize().
In firmware_upload_register(), if alloc_lookup_fw_priv() fails after fw_create_instance() succeeds, the code reaches free_fw_sysfs and frees fw_sysfs directly instead of releasing the device reference with put_device(). This may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak.
The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix this by using put_device(fw_dev) in the failure path and letting fw_dev_release() handle the final cleanup, instead of freeing the instance directly from the error path.
From the CVE record · Linux
The Linux kernel firmware loader can leak a device reference if allocation fails during firmware upload registration. The input does not describe an attacker path, required access, or user interaction.
Engineers running the Linux kernel should check their versions; affected versions are not specified.