usb: gadget: composite: fix dead empty check in the USB_DT_OTG handler
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 53e6242db8d60da0587d36951cc9434d1a1c21dd · < 01feaf024f29618d5ffa7ab0fd858e0579dcbf7b| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
usb: gadget: composite: fix dead empty check in the USB_DT_OTG handler
The OTG branch of composite_setup() falls back to the first configuration when none is selected:
if (cdev->config) config = cdev->config; else config = list_first_entry(&cdev->configs, struct usb_configuration, list); if (!config) goto done; ... memcpy(req->buf, config->descriptors[0], value);
list_first_entry() never returns NULL. On an empty list it returns container_of() of the list head. So the "if (!config)" check is dead.
When cdev->configs is empty, config points at the head inside struct usb_composite_dev. config->descriptors[0] reads whatever sits at that offset. The memcpy copies up to w_length bytes of it into the response buffer.
cdev->configs can be empty in two cases. One is a teardown race on gadget unbind with a control transfer in flight. The other is a driver that sets is_otg before it adds a config. A reproducer that holds cdev->configs empty triggers a KASAN fault in this branch.
Use list_first_entry_or_null() so the existing check does its job.
From the CVE record · Linux
The Linux kernel’s USB gadget composite OTG handler can read unintended memory when its configuration list is empty. A USB host sending a control request during gadget teardown or before a driver adds a configuration can trigger the faulty read and a KASAN fault; the input does not specify authentication requirements.
Engineers running Linux kernels with USB gadget composite support should check their kernel’s status; affected versions are not specified.