mm: do file ownership checks with the proper mount idmap
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 9caccd41541a6f7d6279928d9f971f6642c361af · < 04ba248d02d9eaa3d9077b00a6134caa75fa3e90| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
mm: do file ownership checks with the proper mount idmap
Ever since idmapped mounts were introduced, inode ownership checks (for side-channel protection) in mincore() and madvise(MADV_PAGEOUT) were done against the nop_mnt_idmap, which completely ignores the file's mount's idmap. This results in odd edgecases like:
1) mount/bind-mount with an idmap userA:userB:1 2) userB runs an owner_or_capable() check on file that is owned by userA on-disk/in-memory, but owned by userB after idmap translation 3) owner_or_capable() mysteriously fails as the correct idmap wasn't supplied
In the case of mincore/madvise MADV_PAGEOUT, this is usually benign, because file_permission(file, MAY_WRITE) will probably succeed, as it uses the proper idmap internally, but it does not need to be the case on e.g a 0444 file where even the owner itself doesn't have permissions to write to it.
Since this is clearly not trivial to get right, introduce a file_owner_or_capable() that can carry the correct semantics, and switch the various users in mm to it.
The issue was found by manual code inspection & an off-list discussion with Jan Kara.
From the CVE record · Linux
The Linux kernel uses the wrong mount ID map for file ownership checks in mincore() and madvise(MADV_PAGEOUT). A local user accessing a file through an idmapped mount can fail an ownership check even when the mount maps the file to that user, particularly when the file is not writable. No authentication or additional user interaction is described.
Engineers running Linux kernels that use idmapped mounts should check whether their kernels are affected; no affected versions are specified.