sysfs: don't remove existing directory on update failure
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ c855cf2759d27142f771173d9fd8e7fdf9cf5138 · < 48fa96538bd2868034d33429e4565fda384d0736| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
sysfs: don't remove existing directory on update failure
When sysfs_update_group() is called for a named group and create_files() fails (e.g. -ENOMEM), internal_create_group() calls kernfs_remove(kn) on the group directory. In the update path, kn was obtained via kernfs_find_and_get() and refers to a directory that already existed before this call. Removing it silently destroys a sysfs group that the caller did not create.
Only remove the directory if we created it ourselves. On update failure the directory remains as it is left empty by remove_files() inside create_files(), but can be repopulated by a retry.
From the CVE record · Linux
A failed update to a named sysfs group can remove a directory that existed before the update. This happens if file creation fails, for example because of insufficient memory; the input does not describe an attacker path or specify network access, authentication, or user interaction requirements.
Engineers running the Linux kernel should check their versions against the vendor advisory; affected versions are not specified.