fhandle: fix UAF due to unlocked ->mnt_ns read in may_decode_fh()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
fhandle: fix UAF due to unlocked ->mnt_ns read in may_decode_fh()
may_decode_fh() accesses mount::mnt_ns without holding any locks; that means the mount can concurrently be unmounted, and the mnt_namespace can concurrently be freed after an RCU grace period.
This race can happens as follows, assuming that the mount point was created by open_tree(..., OPEN_TREE_CLONE):
thread 1 thread 2 RCU __do_sys_open_by_handle_at do_handle_open handle_to_path may_decode_fh is_mounted [mount::mnt_ns access] [mount::mnt_ns access] __do_sys_close fput_close_sync __fput dissolve_on_fput umount_tree class_namespace_excl_destructor namespace_unlock free_mnt_ns mnt_ns_tree_remove call_rcu(mnt_ns_release_rcu) mnt_ns_release_rcu mnt_ns_release kfree [mnt_namespace::user_ns access] **UAF**
Fix it by taking rcu_read_lock() around the mount::mnt_ns access, like in __prepend_path(). Additionally, document the semantics of mount::mnt_ns, and use WRITE_ONCE() for writers that can race with lockless readers.
This bug is unreachable unless one of the following is set:
- CONFIG_PREEMPTION - CONFIG_RCU_STRICT_GRACE_PERIOD
From the CVE record · Linux
The Linux kernel's may_decode_fh() can read a freed mount namespace during a race between opening a file handle and unmounting a cloned mount. A local caller able to trigger this race could cause a kernel crash or endless loop, or expose the result of an integer comparison; the bug is reachable only with CONFIG_PREEMPTION or CONFIG_RCU_STRICT_GRACE_PERIOD enabled.
Engineers running Linux kernels with CONFIG_PREEMPTION or CONFIG_RCU_STRICT_GRACE_PERIOD enabled should check whether their kernel includes the fix.