goshs: Share-link ?token=… redemption races past download limit
patrickhener goshs
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| goshs.de/goshs/v2 Go |
|
|
| goshs.de/goshs Go |
| No fix yet |
Original description
goshs is a SimpleHTTPServer written in Go. Prior to version 2.1.0, `ShareHandler` reads the share token's `DownloadLimit` under `RLock`, releases the lock, serves the file, then re-acquires the lock to increment the counter. Concurrent requests all read the same `Downloaded`/`DownloadLimit` snapshot, all pass the check, and all are served — exceeding the operator's intended cap. Version 2.1.0 patches the issue.