regulator: core: fix locking in regulator_resolve_supply() error path
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 36a1f1b6ddc6d1442424e29548e790633ca39c7b · < bde74af8d4466213007bdd42cc85fa72c861dea7| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
regulator: core: fix locking in regulator_resolve_supply() error path
If late enabling of a supply regulator fails in regulator_resolve_supply(), the code currently triggers a lockdep warning:
WARNING: drivers/regulator/core.c:2649 at _regulator_put+0x80/0xa0, CPU#6: kworker/u32:4/596 ... Call trace: _regulator_put+0x80/0xa0 (P) regulator_resolve_supply+0x7cc/0xbe0 regulator_register_resolve_supply+0x28/0xb8
as the regulator_list_mutex must be held when calling _regulator_put().
To solve this, simply switch to using regulator_put().
While at it, we should also make sure that no concurrent access happens to our rdev while we clear out the supply pointer. Add appropriate locking to ensure that.
While the code in question will be removed altogether in a follow-up commit, I believe it is still beneficial to have this corrected before removal for future reference.
From the CVE record · Linux
The Linux kernel regulator core has a locking error when late enabling of a supply regulator fails in regulator_resolve_supply(). This can trigger a lockdep warning; the input does not describe an attacker action, access requirements, or user interaction.
Engineers running the Linux kernel should check whether their build includes the affected regulator core code; affected versions are not specified.