drm/msm/gem: fix error handling in msm_ioctl_gem_info_get_metadata()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
drm/msm/gem: fix error handling in msm_ioctl_gem_info_get_metadata()
msm_ioctl_gem_info_get_metadata() always returns 0 regardless of errors. When copy_to_user() fails or the user buffer is too small, the error code stored in ret is ignored because the function unconditionally returns 0. This causes userspace to believe the ioctl succeeded when it did not.
Additionally, kmemdup() can return NULL on allocation failure, but the return value is not checked. This leads to a NULL pointer dereference in the subsequent copy_to_user() call.
Add the missing NULL check for kmemdup() and return ret instead of 0.
Note that the SET counterpart (msm_ioctl_gem_info_set_metadata) correctly returns ret.
Patchwork: https://patchwork.freedesktop.org/patch/714478/
From the CVE record · Linux
The Linux kernel's msm_ioctl_gem_info_get_metadata() does not check whether an allocation failed and always reports success even when copying metadata to userspace fails. A local caller using this ioctl can encounter a NULL pointer dereference if the allocation fails; no network access or other user interaction is described.
Engineers running Linux kernels with the drm/msm/gem component should check their kernel; affected versions are not specified.