ALSA: caiaq: Handle probe errors properly
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 8e3cd08ed8e590952aa9a656758cb24d4ba898f8 · < e59ecd4ee3a450db6cb4e4ecaa3efdd593f80056| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
ALSA: caiaq: Handle probe errors properly
The probe procedure of setup_card() in caiaq driver doesn't treat the error cases gracefully, e.g. the error from snd_card_register() calls snd_card_free() but continues. This would lead to a UAF for the further calls like snd_usb_caiaq_control_init(), as Berk suggested in another patch in the link below.
However, the problem is not only that; in general, this function drops the all error handlings (as it's a void function) although its caller can propagate an error to snd_probe(), which eventually calls snd_card_free() as a proper error path. That said, we should treat each error case in setup_card(), and just return the error code promptly, which is then handled later as a fatal error in snd_probe().
This patch achieves it by changing the setup_card() to return an error code. Also, the superfluous snd_card_free() call is removed, too.
Note that card->private_free can be set still safely at returning an error. All called functions in card_free() have checks of the unassigned resources or NULL checks.
From the CVE record · Linux
The Linux kernel’s ALSA caiaq driver can continue probing after an error has freed a sound card, causing a use-after-free in later calls. The input does not establish how an attacker could trigger the error or whether access, authentication, or user interaction is required.
Engineers running Linux kernels with the ALSA caiaq driver should check their kernel versions; affected versions are not specified.