e1000/e1000e: Fix leak in DMA error cleanup
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ c1fa347f20f17f14a4a1575727fa24340e8a9117 · < 30e87ade8d678c25a8546cf38c0b498fa5cb27d3| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
e1000/e1000e: Fix leak in DMA error cleanup
If an error is encountered while mapping TX buffers, the driver should unmap any buffers already mapped for that skb.
Because count is incremented after a successful mapping, it will always match the correct number of unmappings needed when dma_error is reached. Decrementing count before the while loop in dma_error causes an off-by-one error. If any mapping was successful before an unsuccessful mapping, exactly one DMA mapping would leak.
In these commits, a faulty while condition caused an infinite loop in dma_error: Commit 03b1320dfcee ("e1000e: remove use of skb_dma_map from e1000e driver") Commit 602c0554d7b0 ("e1000: remove use of skb_dma_map from e1000 driver")
Commit c1fa347f20f1 ("e1000/e1000e/igb/igbvf/ixgb/ixgbe: Fix tests of unsigned in *_tx_map()") fixed the infinite loop, but introduced the off-by-one error.
This issue may still exist in the igbvf driver, but I did not address it in this patch.
From the CVE record · Linux
The Linux kernel’s e1000 and e1000e drivers can leak one DMA mapping during TX buffer error cleanup if a successful mapping is followed by a failed one. The input does not establish whether an attacker can trigger this condition, or specify any authentication or user-interaction requirements.
Engineers running Linux kernels with the e1000 or e1000e drivers should check their kernel versions; affected versions are not specified.