PCI: Fix pci_slot_trylock() error handling
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ a4e772898f8bf2e7e1cf661a12c60a5612c4afab · < bd435f4b738130d732ef64e0e57e45185f77165d| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
PCI: Fix pci_slot_trylock() error handling
Commit a4e772898f8b ("PCI: Add missing bridge lock to pci_bus_lock()") delegates the bridge device's pci_dev_trylock() to pci_bus_trylock() in pci_slot_trylock(), but it forgets to remove the corresponding pci_dev_unlock() when pci_bus_trylock() fails.
Before a4e772898f8b, the code did:
if (!pci_dev_trylock(dev)) /* <- lock bridge device */ goto unlock; if (dev->subordinate) { if (!pci_bus_trylock(dev->subordinate)) { pci_dev_unlock(dev); /* <- unlock bridge device */ goto unlock; } }
After a4e772898f8b the bridge-device lock is no longer taken, but the pci_dev_unlock(dev) on the failure path was left in place, leading to the bug.
This yields one of two errors:
1. A warning that the lock is being unlocked when no one holds it. 2. An incorrect unlock of a lock that belongs to another thread.
From the CVE record · Linux
The Linux kernel’s PCI slot locking code can release a bridge-device lock it did not acquire when pci_bus_trylock() fails. This can trigger a warning or unlock a lock held by another thread. The input does not establish how an attacker could trigger this, or whether access or user interaction is required.
Anyone running the Linux kernel should check whether their version includes the affected PCI locking code; affected versions are not specified.