usb: gadget: f_hid: move list and spinlock inits from bind to alloc
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ cb382536052fcc7713988869b54a81137069e5a9 · < 5d1bb391ceeebb28327703dd07af8c6324af298f| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
usb: gadget: f_hid: move list and spinlock inits from bind to alloc
There was an issue when you did the following: - setup and bind an hid gadget - open /dev/hidg0 - use the resulting fd in EPOLL_CTL_ADD - unbind the UDC - bind the UDC - use the fd in EPOLL_CTL_DEL
When CONFIG_DEBUG_LIST was enabled, a list_del corruption was reported within remove_wait_queue (via ep_remove_wait_queue). After some debugging I found out that the queues, which f_hid registers via poll_wait were the problem. These were initialized using init_waitqueue_head inside hidg_bind. So effectively, the bind function re-initialized the queues while there were still items in them.
The solution is to move the initialization from hidg_bind to hidg_alloc to extend their lifetimes to the lifetime of the function instance.
Additionally, I found many other possibly problematic init calls in the bind function, which I moved as well.
From the CVE record · Linux
The Linux kernel’s USB HID gadget function reinitializes wait queues during bind while they may still contain entries. A local user with access to /dev/hidg0 who registers its file descriptor with epoll and unbinds and rebinds the UDC can trigger list corruption when removing the descriptor from epoll.
Engineers running Linux kernels that use the USB HID gadget function should check whether their kernel includes the fix; affected versions were not provided.