ksmbd: require minimum ACE size in smb_check_perm_dacl()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ e2f34481b24db2fd634b5edb0a5bd0e4d38cc6e9 · < 151b1799861fde38087c08f613abc2843ef597b0| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
ksmbd: require minimum ACE size in smb_check_perm_dacl()
Both ACE-walk loops in smb_check_perm_dacl() only guard against an under-sized remaining buffer, not against an ACE whose declared `ace->size` is smaller than the struct it claims to describe:
if (offsetof(struct smb_ace, access_req) > aces_size) break; ace_size = le16_to_cpu(ace->size); if (ace_size > aces_size) break;
The first check only requires the 4-byte ACE header to be in bounds; it does not require access_req (4 bytes at offset 4) to be readable. An attacker who has set a crafted DACL on a file they own can declare ace->size == 4 with aces_size == 4, pass both checks, and then
granted |= le32_to_cpu(ace->access_req); /* upper loop */ compare_sids(&sid, &ace->sid); /* lower loop */
reads access_req at offset 4 (OOB by up to 4 bytes) and ace->sid at offset 8 (OOB by up to CIFS_SID_BASE_SIZE + SID_MAX_SUB_AUTHORITIES * 4 bytes).
Tighten both loops to require
From the CVE record · Linux
The Linux kernel’s ksmbd component insufficiently validates ACE sizes and SID sub-authority counts when checking file permissions. An authenticated SMB client who can set an ACL on a file can trigger an out-of-bounds read when that file is subsequently opened; this is not a pre-authentication issue, and the read is not reflected to the attacker.
Administrators running Linux kernels with ksmbd should check whether their kernel includes the fix; affected versions were not provided.