HID: core: clamp report_size in s32ton() to avoid undefined shift
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ dde5845a529ff753364a6d1aea61180946270bfa · < 8a8333237f1f5caab8d4c3d2c2e7578c4263a97f| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
HID: core: clamp report_size in s32ton() to avoid undefined shift
s32ton() shifts by n-1 where n is the field's report_size, a value that comes directly from a HID device. The HID parser bounds report_size only to <= 256, so a broken HID device can supply a report descriptor with a wide field that triggers shift exponents up to 256 on a 32-bit type when an output report is built via hid_output_field() or hid_set_field().
Commit ec61b41918587 ("HID: core: fix shift-out-of-bounds in hid_report_raw_event") added the same n > 32 clamp to the function snto32(), but s32ton() was never given the same fix as I guess syzbot hadn't figured out how to fuzz a device the same way.
Fix this up by just clamping the max value of n, just like snto32() does.
From the CVE record · Linux
The Linux kernel’s HID core does not clamp a device-supplied report_size in s32ton(), allowing a malformed HID report descriptor to trigger an undefined shift. This can occur when an output report is built through hid_output_field() or hid_set_field(); the input does not specify authentication or user-interaction requirements.
Engineers running Linux kernels that have not received the s32ton() report_size clamp should check their installations; affected versions are not specified.