nfc: nci: fix circular locking dependency in nci_close_device
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 6a2968aaf50c7a22fced77a5e24aa636281efca8 · < d89b74bf08f067b55c03d7f999ba0a0e73177eb3| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
nfc: nci: fix circular locking dependency in nci_close_device
nci_close_device() flushes rx_wq and tx_wq while holding req_lock. This causes a circular locking dependency because nci_rx_work() running on rx_wq can end up taking req_lock too:
nci_rx_work -> nci_rx_data_packet -> nci_data_exchange_complete -> __sk_destruct -> rawsock_destruct -> nfc_deactivate_target -> nci_deactivate_target -> nci_request -> mutex_lock(&ndev->req_lock)
Move the flush of rx_wq after req_lock has been released. This should safe (I think) because NCI_UP has already been cleared and the transport is closed, so the work will see it and return -ENETDOWN.
NIPA has been hitting this running the nci selftest with a debug kernel on roughly 4% of the runs.
From the CVE record · Linux
The Linux kernel's NFC NCI code flushes work queues while holding a lock that receive work may also need, creating a circular locking dependency. The issue has been observed during the NCI selftest on a debug kernel; the input does not establish whether an attacker can trigger it or what access would be required.
Engineers running Linux kernels with NFC NCI support should check their affected versions against the kernel advisory; no version range was provided.