soc: fsl: qbman: fix race condition in qman_destroy_fq
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ c535e923bb97a4b361e89a6383693482057f8b0c · < 85dbbf7dc88b0a54f2e334daedf6f3f31fd004fa| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
soc: fsl: qbman: fix race condition in qman_destroy_fq
When QMAN_FQ_FLAG_DYNAMIC_FQID is set, there's a race condition between fq_table[fq->idx] state and freeing/allocating from the pool and WARN_ON(fq_table[fq->idx]) in qman_create_fq() gets triggered.
Indeed, we can have: Thread A Thread B qman_destroy_fq() qman_create_fq() qman_release_fqid() qman_shutdown_fq() gen_pool_free() -- At this point, the fqid is available again -- qman_alloc_fqid() -- so, we can get the just-freed fqid in thread B -- fq->fqid = fqid; fq->idx = fqid * 2; WARN_ON(fq_table[fq->idx]); fq_table[fq->idx] = fq; fq_table[fq->idx] = NULL;
And adding some logs between qman_release_fqid() and fq_table[fq->idx] = NULL makes the WARN_ON() trigger a lot more.
To prevent that, ensure that fq_table[fq->idx] is set to NULL before gen_pool_free() is called by using smp_wmb().
From the CVE record · Linux
The Linux kernel’s QMan code has a race between destroying and creating a frame queue when QMAN_FQ_FLAG_DYNAMIC_FQID is set. Concurrent operations can reuse an ID before its table entry is cleared, triggering a WARN_ON warning. The input does not specify an attacker path, authentication requirements, or user interaction.
Engineers running Linux kernels that use the affected QMan code should check their systems; affected versions are not specified.