net/rds: Fix circular locking dependency in rds_tcp_tune
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 3a58f13a881ed351198ffab4cf9953cf19d2ab3a · < 6a877ececd6daa002a9a0002cd0fbca6592a9244| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
net/rds: Fix circular locking dependency in rds_tcp_tune
syzbot reported a circular locking dependency in rds_tcp_tune() where sk_net_refcnt_upgrade() is called while holding the socket lock:
====================================================== WARNING: possible circular locking dependency detected ====================================================== kworker/u10:8/15040 is trying to acquire lock: ffffffff8e9aaf80 (fs_reclaim){+.+.}-{0:0}, at: __kmalloc_cache_noprof+0x4b/0x6f0
but task is already holding lock: ffff88805a3c1ce0 (k-sk_lock-AF_INET6){+.+.}-{0:0}, at: rds_tcp_tune+0xd7/0x930
The issue occurs because sk_net_refcnt_upgrade() performs memory allocation (via get_net_track() -> ref_tracker_alloc()) while the socket lock is held, creating a circular dependency with fs_reclaim.
Fix this by moving sk_net_refcnt_upgrade() outside the socket lock critical section. This is safe because the fields modified by the sk_net_refcnt_upgrade() call (sk_net_refcnt, ns_tracker) are not accessed by any concurrent code path at this point.
v2: - Corrected fixes tag - check patch line wrap nits - ai commentary nits
From the CVE record · Linux
The Linux kernel's rds_tcp_tune() can create a circular locking dependency by allocating memory while holding a socket lock. This may cause a deadlock; the input does not specify whether an attacker can trigger it or what access or interaction would be required.
Engineers running Linux kernels with RDS TCP support should check their deployments; affected versions are not specified.