MISP Missing Authorization in Sync Proposal Endpoints Allows Cross-Event Data Access and Modification
misp
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| misp misp |
| No fix yet |
Original description
MISP contains an authorization bypass in its server-to-server proposal synchronization mechanism. Two related flaws were identified:
1. The events/pushProposals endpoint located the target event by UUID without enforcing any access-control check. A sync user with perm_sync could push shadow-attribute proposals to any event on the local instance, including events with restricted distribution (e.g., distribution level 0, visible only to the owning organisation). The stored proposal also carried the sender-supplied event_uuid and event_org_id rather than the local event's actual identity, corrupting the data model.
2. When accepting an edit proposal (old_id != 0), the code resolved the target live attribute by UUID alone (Attribute.uuid = shadow.uuid) without scoping the lookup to the proposal's own event. A malicious sync user could therefore craft a proposal whose uuid matched an attribute in a different event; upon acceptance, the wrong attribute would be modified or deleted. The same unscoped lookup existed in the ShadowAttribute::acceptProposal path.